DB Tabelle Update funktioniert nicht (WHERE id)

[theoq]

Guten Abend,

ich versuche seit 3 Tagen ein Problem mit dem Update meiner Tabelle zu lösen,
jedoch ohne Erfolg. Auch mit Google habe ich gesucht aber nicht die passende Lösung gefunden. Wahrscheinlich ein Maskierunggsfehler oder?
Ich hoffe ihr könnt mir weiterhelfen!

Wenn ich folgendes eingebe: WHERE id = 1 dann klappt es!
Auf dieser weise leider nicht: WHERE id = $_GET["id"]

Danke sehr im Voraus


Hier der Code:

[PHP

<form action='" . $_SERVER["SCRIPT_NAME"] . "' autocomplete='off' method='post'>.......................................
.............................


$Update = $pdo->prepare("UPDATE `cars`
SET
`title` = :title,
`cond` = :cond,
`manufacturer` = :manufacturer,
`model` = :model,
`price` = rice,
`bodytype` = :bodytype,
`fuel` = :fuel,
`door` = :door,
`curency` = :curency,
`mileage` = :mileage,
`power` = ower,
`cubic` = :cubic,
`transmission` = :transmission,
`aircondition` = :aircondition,
`airbag` = :airbag,
`regcountry` = :regcountry,
`regdate` = :regdate,
`drivetrain` = :drivetrain,
`description` = :description,
`location` = :location WHERE id = 1
");

$Update->bindValue(":title", $title);
$Update->bindValue(":cond", $cond);
$Update->bindValue(":manufacturer", $manufacturer);
$Update->bindValue(":model", $model);
$Update->bindValue("rice", $price);
$Update->bindValue(":bodytype", $bodytype);
$Update->bindValue(":fuel", $fuel);
$Update->bindValue(":door", $door);
$Update->bindValue(":curency", $curency);
$Update->bindValue(":mileage", $mileage);
$Update->bindValue("ower", $power);
$Update->bindValue(":cubic", $cubic);
$Update->bindValue(":transmission", $transmission);
$Update->bindValue(":aircondition", $aircondition);
$Update->bindValue(":airbag", $airbag);
$Update->bindValue(":regcountry", $regcountry);
$Update->bindValue(":regdate", $regdate);
$Update->bindValue(":drivetrain", $drivetrain);
$Update->bindValue(":description", $description);
$Update->bindValue(":location", $map);


][/PHP]

[Kropff]

auf die Schnelle:

`location` = :location WHERE id = :id;
...
$Update->bindValue(":id", $_GET["id"]); 

So???

Gruß
Peter

PS: bei $_GET["id"] muss zumindest eine Typeprüfung à la (int) $_GET["id"]) stattfinden.

Nachtrag: Niemals einen GET-Parameter ungeprüft übernehmen!

[theoq]

Danke Peter, aber irgendwie funktioniert es immer noch nicht!
Die Erfolgsmeldung kommt, aber in der Tabelle passiert nichts.

Hier der koplette Code:

[theoq]

<?php
$statement = $pdo->prepare("SELECT * FROM cars WHERE id=".$_GET["id"]);
            $result = $statement->execute();
            $count = 1;
            while($row = $statement->fetch())
            {

require_once("add_car_var.php");
?>

        <div class="row">

                <div class="col-12 col-md-6 col-xl-4"><br>
                    <div class="single-featured-item mb-50">
                        <!-- item Thumbnail -->
                        <div class="item-thumb">
                            <img src="<?php echo $images[0]; ?>">
                            <div class="tag">
                        
                            </div>
                            <div class="list-price">
                                <p><?php echo $row['price'].'&nbsp;'.$row['curency']; ?></p>
                            </div>
                        </div>
                    </div>
                </div>
                        <!-- item Content -->
                        <div class="col-12 col-md-6 col-xl-8"><br>
                            <div class="item-content">
                                <h5><?php echo $row['title']; ?></h5>
                                <div class="new">
                                <h6>ID <?php echo $row['id']; ?></h6>
                                </div>
                                <?php if($scond == "New Car") : ?>
                                <div class="new-tag">New Car 
                                    <i class="fa fa-star-o"></i>
                                </div>
                                <?php else : ?>
                                <div class="used-tag">Used Car 
                                    <i class="fa fa-star"></i>
                                </div>
                                <?php endif; ?>
                            <br>
                                <a class="btn btn-primary" href="cars.php">Abort</a>
                            </div>
                            <hr>
                        </div>
                        
        </div><!-- ROW -->

<?php
// Form
$Form = "
<form action='" . $_SERVER["SCRIPT_NAME"] . "' autocomplete='off' method='post'>

<h3>Car Data</h3>
<br>
    
<div class='row text-center pad-top'>
    
        <div class='col-lg-12 col-md-12 col-sm-12 col-xs-12'>
        <p>
        <label>Title:
        <input type='text' name='title' value='" . $title . "' size='100' placeholder='" . $scartitle . "' class='form-control' tabindex='0'>
        <input type='text' name='id' value='" . $id . "' size='100' placeholder='" . $scarid . "' class='form-control' tabindex='0'>
        </label>
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw0'>Condition:</label><br>
        " . $carcondAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw1'>Body Type:</label><br>
        " . $carbodytypeAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw2'>Fuel Type:</label><br>
        " . $carfuelAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Manufacturer:
        <input type='text' name='manufacturer' value='" . $manufacturer . "' size='35' placeholder='" . $scarmanufacturer . "' class='form-control' tabindex='1'>
        </label>
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Model:
        <input type='text' name='model' value='" . $model . "' size='35' placeholder='" . $scarmodel . "' class='form-control' tabindex='2'>
        </label>
        </p><br>
        </div>    
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Mileage:
        <input type='text' name='mileage' value='" . $mileage . "' size='35' placeholder='" . $scarmileage . "' class='form-control' tabindex='3'>
        </label>
        </p><br>
        </div>        
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Power:
        <input type='text' name='power' value='" . $power . "' size='35' placeholder='" . $scarpower . "' class='form-control' tabindex='4'>
        </label>
        </p><br>
        </div>        
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Cubic Capacity:
        <input type='text' name='cubic' value='" . $cubic . "' size='35' placeholder='" . $scarcubic . "' class='form-control' tabindex='5'>
        </label>
        </p><br>
        </div>        

        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Doors:
        <input type='text' name='door' value='" . $door . "' size='35' placeholder='" . $scardoor . "' class='form-control' tabindex='6'>
        </label>
        </p><br>
        </div>            
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw3'>Transmission:</label><br>
        " . $cartransmissionAW . "
        </p><br>
        </div>        

        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw6'>Drivetrain:</label><br>
        " . $cardrivetrainAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw4'>Air conditioning:</label><br>
        " . $carairconditionAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Exterior Colour:
        <input type='text' name='excolor' value='" . $excolor . "' size='35' placeholder='" . $scarexcolor . "' class='form-control' tabindex='7'>
        </label>
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Interior Colour:
        <input type='text' name='intcolor' value='" . $intcolor . "' size='35' placeholder='" . $scarintcolor . "' class='form-control' tabindex='8'>
        </label>
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label for='aw5'>Airbags:</label><br>
        " . $carairbagAW . "
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Country of registration:
        <input type='text' name='regcountry' value='" . $regcountry . "' size='35' placeholder='" . $scarregcountry . "' class='form-control' tabindex='9'>
        </label>
        </p><br>
        </div>
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>First registration:
        <input type='text' name='regdate' value='" . $regdate . "' size='35' placeholder='" . $scarregdate . "' class='form-control' tabindex='10'>
        </label>
        </p><br>
        </div>

        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
<!--     <p>
        <label>.
        <input type='text' name='' value='' size='35' placeholder='' class='form-control' tabindex='11' readonly>
        </label>
        </p><br> -->
        </div>    
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Price:
        <input type='text' name='price' value='" . $price . "' size='35' placeholder='" . $scarprice . "' class='form-control' tabindex='12'>
        </label>
        </p><br>
        </div>        
        
        <div class='col-lg-4 col-md-4 col-sm-6 col-xs-12'>
        <p>
        <label>Curency:
        <input type='text' name='curency' value='" . $curency . "' size='35' placeholder='" . $scarcurency . "' class='form-control' tabindex='13'>
        </label>
        </p>
        </div>

</div><!-- /. ROW  -->

<hr>                   
<h3>Description Text</h3>
<br>                  
                  
<p>
 <label> Description:<br>
 <textarea name='description' cols='100' rows='5' spellcheck='false' maxlength='1000' placeholder='' class='form-control' tabindex='1'>" . $scardescription . "</textarea>
 </label>
</p>

        <div class='col-12'>
        <p>
        <label>Location:
        <input type='text' name='location' value='" . $map . "' size='100' placeholder='" . $scarmap . "' class='form-control' tabindex='13'>
        </label>
        </p>
        </div>

        <p>
        <br>
        <input type='submit' name='submit' value='Edit Car' class='btn btn-primary' tabindex='99'>
        </p>


</form>
";

}

if (isset($_POST["submit"])) {

require_once("add_car_var.php");

  // Data update
  $Update = $pdo->prepare("UPDATE `cars`
   SET
    `id` = :id,
    `title` = :title,
    `cond` = :cond, 
    `manufacturer` = :manufacturer,
    `model` = :model,
    `price` = :price,
    `bodytype` = :bodytype,
    `fuel` = :fuel,
    `door` = :door,
    `curency` = :curency,
    `mileage` = :mileage,
    `power` = :power,
    `cubic` = :cubic,
    `transmission` = :transmission,
    `aircondition` = :aircondition,
    `airbag` = :airbag,
    `regcountry` = :regcountry,
    `regdate` = :regdate,
    `drivetrain` = :drivetrain,
    `description` = :description,
    `location` = :location WHERE id = :id;
    ");

  $Update->bindValue(":id", $_GET["id"]);
  $Update->bindValue(":title", $title);
  $Update->bindValue(":cond", $cond);
  $Update->bindValue(":manufacturer", $manufacturer);
  $Update->bindValue(":model", $model);
  $Update->bindValue(":price", $price);
  $Update->bindValue(":bodytype", $bodytype);
  $Update->bindValue(":fuel", $fuel);
  $Update->bindValue(":door", $door);
  $Update->bindValue(":curency", $curency);
  $Update->bindValue(":mileage", $mileage);
  $Update->bindValue(":power", $power);
  $Update->bindValue(":cubic", $cubic);
  $Update->bindValue(":transmission", $transmission);
  $Update->bindValue(":aircondition", $aircondition);
  $Update->bindValue(":airbag", $airbag);
  $Update->bindValue(":regcountry", $regcountry);
  $Update->bindValue(":regdate", $regdate);
  $Update->bindValue(":drivetrain", $drivetrain);
  $Update->bindValue(":description", $description);
  $Update->bindValue(":location", $map);
  
  if ($Update->execute()) {
   echo "<div class='row'><div class='col-lg-12 '>
                        <div class='alert alert-info'>
                             <strong>Car Data successfully changed!</strong>
                        </div>
                    </div>
                </div>
        <br><blockquote>If it is not automatically forwarded, please <a href='cars.php'>click here</a>.</blockquote>";
  }
  else {
   echo "<div class='row'><div class='col-lg-12 '>
                        <div class='alert alert-danger'>
                             <strong>Error!</strong>
                        </div>
                    </div>
                </div>
        <br><blockquote>If it is not automatically forwarded, please <a href='cars.php'>click here</a>.</blockquote>";
   //print_r($Update->errorInfo());
  }
}
else {

 echo $Form;
}
?>

[theoq]

add_car_var.php

add_car_var.php:

<?php
// Cars
$sid = $row["id"];
$scond = $row["cond"];
$imgpath = "../../upload/";
$images = glob($imgpath.$sid."/*.{jpg,jpeg,png,gif}", GLOB_BRACE);

if ($title == "") {
$title = $scartitle;
$cond = $scarcond;
$manufacturer = $scarmanufacturer;
$model = $scarmodel;
$bodytype = $scarbodytype;
$fuel = $scarfuel;
$door = $scardoor;
$curency = $scarcurency;
$transmission = $scartransmission;
$aircondition = $scaraircondition;
$airbag = $scarairbag;
$drivetrain = $scardrivetrain;
$regcountry = $scarregcountry;
$mileage = $scarmileage;
$power = $scarpower;
$cubic = $scarcubic;
$regdate = $scarregdate;
$price = $scarprice;
$description = $scarcdescription;
$map = $scarmap;
}

$scarid = $row['id'];
$scartitle = $row['title'];
$scarcond = $row['cond'];
$scarmanufacturer = $row['manufacturer'];
$scarmodel = $row['model'];
$scarbodytype = $row['bodytype'];
$scarfuel = $row['fuel'];
$scardoor = $row['door'];
$scarcurency = $row['curency'];
$scartransmission = $row['transmission'];
$scaraircondition = $row['aircondition'];
$scarairbag = $row['airbag'];
$scardrivetrain = $row['drivetrain'];
$scarregcountry = $row['regcountry'];
$scarmileage = $row['mileage'];
$scarpower = $row['power'];
$scarcubic = $row['cubic'];
$scarregdate = $row['regdate'];
$scarprice = $row['price'];
$scardescription = $row['description'];
$scarmap = $row['location'];

$title = isset($_POST["title"]) ? trim($_POST["title"]) : "";
$cond = isset($_POST["cond"]) ? $_POST["cond"] : "";
$manufacturer = isset($_POST["manufacturer"]) ? trim($_POST["manufacturer"]) : "";
$model = isset($_POST["model"]) ? trim($_POST["model"]) : "";
$bodytype = isset($_POST["bodytype"]) ? $_POST["bodytype"] : "";
$fuel = isset($_POST["fuel"]) ? $_POST["fuel"] : "";
$door = isset($_POST["door"]) ? trim($_POST["door"]) : "";
$curency = isset($_POST["curency"]) ? trim($_POST["curency"]) : "";
$transmission = isset($_POST["transmission"]) ? $_POST["transmission"] : "";
$aircondition = isset($_POST["aircondition"]) ? $_POST["aircondition"] : "";
$airbag = isset($_POST["airbag"]) ? $_POST["airbag"] : "";
$drivetrain = isset($_POST["drivetrain"]) ? $_POST["drivetrain"] : "";
$regcountry = isset($_POST["regcountry"]) ? trim($_POST["regcountry"]) : "";
$mileage = isset($_POST["mileage"]) ? trim($_POST["mileage"]) : "";
$power = isset($_POST["power"]) ? trim($_POST["power"]) : "";
$cubic = isset($_POST["cubic"]) ? trim($_POST["cubic"]) : "";
$regdate = isset($_POST["regdate"]) ? trim($_POST["regdate"]) : "";
$price = isset($_POST["price"]) ? trim($_POST["price"]) : "";
$description = isset($_POST["description"]) ? trim($_POST["description"]) : "";
$map = isset($_POST["location"]) ? trim($_POST["location"]) : "";

// Condition
$array = [
"$scarcond", 
"New Car", 
"Used Car", 
];
$carcondAW = "<select name='cond' size='1' class='form-control' id='aw0' tabindex='1'>";
foreach ($array as $value) {
 $carcondAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["cond"]) ? $_POST["cond"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$carcondAW .= "\n </select>";


// Body Type
$array = [
"$scarbodytype", 
"Cabriolet",
"Sport Car",
"Estate Car",
"Off-road",
"Saloon",
"Van",
"Small Car", 
];
$carbodytypeAW = "<select name='bodytype' size='1' class='form-control' id='aw1' tabindex='2'>";
foreach ($array as $value) {
 $carbodytypeAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["bodytype"]) ? $_POST["bodytype"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$carbodytypeAW .= "\n </select>";


// Fuel Type
$array = [
"$scarfuel",
"Petrol",
"Diesel",
"Hybrid",
"Hydrogen",
"LPG",
"Ethanol",
"Natural Gas", 
];
$carfuelAW = "<select name='fuel' size='1' class='form-control' id='aw2' tabindex='3'>";
foreach ($array as $value) {
 $carfuelAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["fuel"]) ? $_POST["fuel"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$carfuelAW .= "\n </select>";


// Transmission
$array = [
"$scartransmission",
"Manual",
"Semi-automatic",
"Automatic", 
];
$cartransmissionAW = "<select name='transmission' size='1' class='form-control' id='aw3' tabindex='4'>";
foreach ($array as $value) {
 $cartransmissionAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["transmission"]) ? $_POST["transmission"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$cartransmissionAW .= "\n </select>";


// Air conditioning
$array = [
"$scaraircondition",
"No climatisation",
"Manual",
"Manual or automatic ",
"Automatic",
"2 zones",
"3 zones",
"4 zones",
];
$carairconditionAW = "<select name='aircondition' size='1' class='form-control' id='aw4' tabindex='5'>";
foreach ($array as $value) {
 $carairconditionAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["aircondition"]) ? $_POST["aircondition"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$carairconditionAW .= "\n </select>";


// Airbags
$array = [
"$scarairbag",
"Driver",
"Front",
"Front & Side",
"More",
];
$carairbagAW = "<select name='airbag' size='1' class='form-control' id='aw5' tabindex='6'>";
foreach ($array as $value) {
 $carairbagAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["airbag"]) ? $_POST["airbag"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$carairbagAW .= "\n </select>";


// Drivetrain
$array = [
"$scardrivetrain",
"4x2",
"4x4",
"AWD",
"FWD",
"RWD",
"Other", 
];
$cardrivetrainAW = "<select name='drivetrain' size='1' class='form-control' id='aw6' tabindex='7'>";
foreach ($array as $value) {
 $cardrivetrainAW .= "\n  <option value='" . $value . "'" .
 ((isset($_POST["drivetrain"]) ? $_POST["drivetrain"] : "") == $value ?
 " selected='selected'" : "") . ">" . $value . "</option>";
}
$cardrivetrainAW .= "\n </select>";
?>

[theoq]

Bitte um Verständnis für den vielleicht aufgeblähten Code!
Bin noch Anfänger in Sachen PHP.

Danke vielmals

[Flavaslava]

Hey theoq,


Ich habe mir deinen Code angeguckt. Es ist so wie du es beschrieben hast, es ist sehr einfach und mit sehr vielen Fehlern geschrieben.


Bitte achte darauf das du ein bestimmten Standard dir angewöhnst und danach programmierst.


Du benutzt Bootstrap ist ja auch nicht falsch aber du hast unnötige Code drinne. Da ich nicht wusste welche du brauchen könntest habe ich diese nicht entfernt.


Es gibt einen Grund wieso wir sagen das man debuggen soll oder das man sauberen code schreiben soll, damit man im falle eines Fehlers es schneller entdecken kann und nicht weil wir spaß daran haben euch zu ärgern.


Statt drei Tage lang nach dem Fehler zu suchen, hättest du lieber dein Code gesäubert. Denn wäre dir der Fehler besser aufgefallen.


Ich habe den Script ausgebessert und den formular in die IF abfrage rein genommen also in die ELSE.


Da du den ID mit GET ausliest. Solltest du überprüfen ob du nachdem der Formular gesendet wurde immer noch den ID oben in dem URL stehen hast.


Ansonsten kannst du den id auch mithilfe von input type="hidden" mitschicken.


Ich habe statt den $_GET, filter_input benutzt. Da $_GET schon veraltet ist und nicht mehr benutzt werden soll. Dies gilt auch für $_POST.


Ich habe verständnis dafür das du noch neu bist aber es gibt doch extra dieses Forum um fragen zu stellen und antworten zu bekommen.



Bitte habe verständnis dafür das ich es so kritisiert habe, du kannst selbstverständlich jederzeit hier etwas fragen.


Da man hier nicht länger als 10000 Zeichen schreiben kann poste ich dir den code in dem zweiten Thred.




Mfg
Flavaslava

[Flavaslava]

Ich muss es in drei teilen. Hier ist die Schleife:



<div>

<?php 
  // Abfrage
  $statement = $pdo->prepare("SELECT * FROM cars WHERE id=".$_GET["id"]);
  $result = $statement->execute();
  $count = 1;

  //Schleife
  while($row = $statement->fetch()) {

    require_once("add_car_var.php");

    ?>

      <!-- ROW -->
      <div class="row">

         <!-- COL -->
         <div class="col-12 col-md-6 col-xl-4"><br>
             <div class="single-featured-item mb-50">
                 <!-- item Thumbnail -->
                 <div class="item-thumb">
                     <img src="<?php echo $images[0]; ?>">
                     <div class="tag"></div>
                     <div class="list-price">
                         <p><?php echo $row['price'].'&nbsp;'.$row['curency']; ?></p>
                     </div>
                 </div>
             </div>
         </div>
         <!-- /COL -->
         <!-- COL item Content -->
         <div class="col-12 col-md-6 col-xl-8"><br>
             <div class="item-content">
                 <h5><?php echo $row['title']; ?></h5>
                 <div class="new">
                   <h6>ID <?php echo $row['id']; ?></h6>
                 </div>
                 <?php if($scond == "New Car") : ?>
                 <div class="new-tag">New Car
                     <i class="fa fa-star-o"></i>
                 </div>
                 <?php else : ?>
                 <div class="used-tag">Used Car
                     <i class="fa fa-star"></i>
                 </div>
                 <?php endif; ?>
                  <br>
                 <a class="btn btn-primary" href="cars.php">Abort</a>
             </div>
             <hr>
         </div>
         <!-- /COL -->
       </div><!-- ROW -->

    <?php
  }
  //Schleife Endet

[Flavaslava]

Hier ist der zweite Teil. Hier kommt die IF Abfrage:

 //If Form Send
  if(isset($_POST["submit"])) {

    require_once("add_car_var.php");

   // Data update
   $Update = $pdo->prepare("UPDATE `cars`
    SET
     `id` = :id,
     `title` = :title,
     `cond` = :cond,
     `manufacturer` = :manufacturer,
     `model` = :model,
     `price` = :price,
     `bodytype` = :bodytype,
     `fuel` = :fuel,
     `door` = :door,
     `curency` = :curency,
     `mileage` = :mileage,
     `power` = :power,
     `cubic` = :cubic,
     `transmission` = :transmission,
     `aircondition` = :aircondition,
     `airbag` = :airbag,
     `regcountry` = :regcountry,
     `regdate` = :regdate,
     `drivetrain` = :drivetrain,
     `description` = :description,
     `location` = :location WHERE id = :id;
     ");

     $Update->bindValue(":id", filter_input(INPUT_GET, "id", FILTER_SANITIZE_NUMBER_INT);
     $Update->bindValue(":title", $title);
     $Update->bindValue(":cond", $cond);
     $Update->bindValue(":manufacturer", $manufacturer);
     $Update->bindValue(":model", $model);
     $Update->bindValue(":price", $price);
     $Update->bindValue(":bodytype", $bodytype);
     $Update->bindValue(":fuel", $fuel);
     $Update->bindValue(":door", $door);
     $Update->bindValue(":curency", $curency);
     $Update->bindValue(":mileage", $mileage);
     $Update->bindValue(":power", $power);
     $Update->bindValue(":cubic", $cubic);
     $Update->bindValue(":transmission", $transmission);
     $Update->bindValue(":aircondition", $aircondition);
     $Update->bindValue(":airbag", $airbag);
     $Update->bindValue(":regcountry", $regcountry);
     $Update->bindValue(":regdate", $regdate);
     $Update->bindValue(":drivetrain", $drivetrain);
     $Update->bindValue(":description", $description);
     $Update->bindValue(":location", $map);

     if ($Update->execute()) {
       ?>
          <!-- ROW -->
          <div class="row">
            <!-- COL -->
            <div class="col-lg-12">
              <!-- ALERT -->
              <div class="alert alert-info">
                <strong>Car Data successfully changed!</strong>
              </div>
              <!-- /ALERT -->
            </div>
            <!-- /COL -->
          </div>
          <!-- /ROW -->
          <br>
          <blockquote>If it is not automatically forwarded, please  <a href="cars.php">click here</a>.</blockquote>
          
       <?php
     }
     else {

       ?>
         <!-- ROW -->
         <div class="row">
           <!-- COL -->
           <div class="col-lg-12">
              <!-- ALERT -->
              <div class="alert alert-danger">
                <strong>Error!</strong>
              </div>
              <!-- /ALERT -->
           </div>
           <!-- /COL -->
         </div>
         <!-- /ROW -->
         <br>
         <blockquote>If it is not automatically forwarded, please  <a href="cars.php">click here</a>.</blockquote>
         
       <?php      
     }
   }

[Flavaslava]

Hier kommt der dritte Teil mit der Else:

 else {
     ?>
     <!-- FORM -->
     <form action="<?php echo $_SERVER["SCRIPT_NAME"]; ?>" autocomplete="off" method="post">
       <h3>Car Data</h3>
       <br>
       <!-- ROW -->
       <div class="row text-center pad-top">
         <!-- COL -->
         <div class="col-lg-12 col-md-12 col-sm-12 col-xs-12">
          <p>
            <label>Title:
              <input type="text" name="title" value="<?php echo   $title; ?>" size="100" placeholder="<?php echo $scartitle; ?>"   class="form-control" tabindex="0">
              <input type="text" name="id" value="<?php echo $id;   ?>" size="100" placeholder="<?php echo $scarid; ?>"   class="form-control" tabindex="0">
            </label>
          </p>
          <br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw0">Condition:</label><br>
             <?php echo $carcondAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw1">Body Type:</label><br>
             <?php echo $carbodytypeAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw2">Fuel Type:</label><br>
             <?php echo $carfuelAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
          <p>
            <label>Manufacturer:
              <input type="text" name="manufacturer" value="<?php   echo $manufacturer; ?>" size="35" placeholder="<?php echo   $scarmanufacturer; ?>" class="form-control" tabindex="1">
            </label>
          </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Model:
               <input type="text" name="model" value="<?php echo   $model; ?>" size="35" placeholder="<?php echo $scarmodel; ?>"   class="form-control" tabindex="2">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Mileage:
               <input type="text" name="mileage" value="<?php echo   $mileage; ?>" size="35" placeholder="<?php echo $scarmileage;   ?>" class="form-control" tabindex="3">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Power:
               <input type="text" name="power" value="<?php echo   $power; ?>" size="35" placeholder="<?php echo $scarpower; ?>"   class="form-control" tabindex="4">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Cubic Capacity:
               <input type="text" name="cubic" value="<?php echo   $cubic; ?>" size="35" placeholder="<?php echo $scarcubic; ?>"   class="form-control" tabindex="5">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Doors:
               <input type="text" name="door" value="<?php echo   $door; ?>" size="35" placeholder="<?php echo $scardoor; ?>"   class="form-control" tabindex="6">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw3">Transmission:</label><br>
             <?php echo $cartransmissionAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw6">Drivetrain:</label><br>
             <?php echo $cardrivetrainAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw4">Air conditioning:</label><br>
             <?hpp echo $carairconditionAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Exterior Colour:
               <input type="text" name="excolor" value="<?php echo   $excolor; ?>" size="35" placeholder="<?php echo $scarexcolor;   ?>" class="form-control" tabindex="7">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Interior Colour:
               <input type="text" name="intcolor" value="<?php   echo $intcolor; ?>" size="35" placeholder="<?php echo   $scarintcolor; ?>" class="form-control" tabindex="8">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label for="aw5">Airbags:</label><br>
             <?php echo $carairbagAW; ?>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Country of registration:
               <input type="text" name="regcountry" value="<?php   echo $regcountry; ?>" size="35" placeholder="<?php echo   $scarregcountry; ?>" class="form-control" tabindex="9">
             </label>
           </p><br>
         </div>
         <!-- /COl -->

         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>First registration:
               <input type="text" name="regdate" value="<?php echo   $regdate; ?>" size="35" placeholder="<?php echo $scarregdate;   ?>" class="form-control" tabindex="10">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <!--     <p>
           <label>.
           <input type="text" name="" value="" size="35" placeholder="" class="form-control" tabindex="11" readonly>
            </label>
            </p><br> -->
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Price:
               <input type="text" name="price" value="<?php echo   $price; ?>" size="35" placeholder="<?php echo $scarprice; ?>"   class="form-control" tabindex="12">
             </label>
           </p><br>
         </div>
         <!-- /COL -->
         <!-- COL -->
         <div class="col-lg-4 col-md-4 col-sm-6 col-xs-12">
           <p>
             <label>Curency:
               <input type="text" name="curency" value="<?php echo   $curency; ?>" size="35" placeholder="<?php echo $scarcurency;   ?>" class="form-control" tabindex="13">
             </label>
           </p>
         </div>
         <!-- /COL -->
       </div>
       <!-- /. ROW  -->
       <hr>
       <h3>Description Text</h3>
       <br>
       <p>
         <label> Description:<br>
           <textarea name="description" cols="100" rows="5"   spellcheck="false" maxlength="1000" placeholder="" class="form-control"   tabindex="1"><?php echo $scardescription; ?></textarea>
         </label>
       </p>
       <div class="col-12">
         <p>
           <label>Location:
             <input type="text" name="location" value="<?php echo   $map; ?>" size="100" placeholder="<?php echo $scarmap; ?>"   class="form-control" tabindex="13">
           </label>
         </p>
       </div>
       <p>
         <br>
         <input type="submit" name="submit" value="Edit Car" class="btn btn-primary" tabindex="99">
       </p>
     </form>
     <!-- /FORM -->
    <?php
  }
  
?>

[theoq]

Danke sehr für deine Hilfe Flavaslava!

Nach der umsetzung des Codes erhalte ich folgenden Fehler:

Parse error: syntax error, unexpected ';', expecting ',' or ')' in P:\xampp\htdocs\cars\admin\add\car_edit_core.php on line 177

Line 177:
$Update->bindValue(":id", filter_input(INPUT_GET, "id", FILTER_SANITIZE_NUMBER_INT);

Habe ich etwas übersehen?

[Flavaslava]

Entschuldige habe wohl dort etwas vergessen.


$Update->bindValue(":id", filter_input(INPUT_GET, "id", FILTER_SANITIZE_NUMBER_INT));

[theoq]

Ich habe gerade die klammer hinzugefügt.
Erfolgsmeldung kommt, aber der Datensatz in der DB bleibt gleich!

wenn ich stattdessen: WHERE id = 1; eintrage wird die Tabelle verändert.

[Flavaslava]

hast du mal überprüft was in der $_GET["id"] steht, also mit echo mal im script angezeigt. Weil das muss ja oben im URL stehen, damit du zugreifen kannst.

[theoq]

Browser Adresszeile:
http://localhost/cars/admin/add/car_edit_core.php?id=1